Add Manifest.toml to .gitignore #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an automated message. |
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 82.40% 82.40%
=======================================
Files 31 31
Lines 2824 2824
=======================================
Hits 2327 2327
Misses 497 497 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just felt that either the Manifest.toml should be checked in to the repo or it should be in the .gitignore file, I don't really see any reason why it should not be one of those two cases.
I found a short discourse thread on this here where there are some mixed opinions, but it seems that most people agree that for a package it is not really necessary. Someone also brings up the point that it might actually be good to have developers have slightly different versions of dependencies to have our package tested over a wider variety of environments, but also brings up the value of having a history of working Manifests stored in the repo.
I'm leaning more towards adding it to the ignore (hence the PR) but mostly feel that just doing either is nicer than having untracked unignored generated files in the repo.